-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby rewrite: Jewler to create a gem layout #63
Comments
I think the best approach here to to use the below gem to interface with. This dependency would be similar to python-gitlab3. But the gem below looks way better. I would be willing to start this gem/rewrite for you but I won't be able to maintain it since I have committed to so many projects already. If you want create a new repo and give me permission to push and I'll get you started. |
@logicminds Rather than that let's create a branch dedicated to the ruby rewrite. In that branch you can manipulate any files you want. I've added you as a contributor. |
I think it should just be a new repo. That way you can have a fresh start. Additionally if someone still wants the bash/python version its still intact. |
@logicminds Please keep in mind that I adhere to the git flow workflow with this project. That means that master is production ready merges only. |
Well for the bash/python implementation there's the prior versions that have been tagged ( I'd rather not fragment the project and just convert it into a gem. |
I don't think it would fragment the project. One is a ruby gem and the other is a set up scripts. Personally these are two different things that just take a similar approach Honestly, its best to have a new repo that way the gem version can match against the repo version. This is huge change and anybody using the current implementation would want to know. Maintaining each code base independently will may it simplier in the long run. The project should be called ruby-gitlab_mirrors |
Fair enough, I've created https://github.com/samrocketman/gitlab-mirrors.rb I've added you as a collaborator so you have RW access to it. |
@logicminds since we can depend on rubygems.org for hosting stable versions I think it's okay to let master branch be bleeding edge development. Only published gems are the stable releases (with tags denoting which version is which). |
Sorry to nag. But this isn’t the “ruby standard”. It should be ruby-gitlab_mirrors. You Can you change to ruby-gitlab-mirrors too if you prefer. I follow gitflow so regarding the comment above thats my normal workflow anyways. |
Not nagging; I renamed the project to |
Since, I haven't really made any progress here and I'm probably not going to in the near future due to other interests... I'm going to abandon the thought of rewriting this in ruby. |
This issue is to track rewriting gitlab-mirrors in ruby instead of bash. This way we get unit testing fun but still have the ability to subshell using back ticks if that's required.
That's the nutshell from #gitlab on IRC freenode.
The text was updated successfully, but these errors were encountered: