This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
graphql: oops wrap json errors with message #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helpful for debugging c.handle errors logged. As a follow up, we should fix up this code path so that errors can be handled by the client code.
berfarah
reviewed
Oct 10, 2018
| @@ -11,6 +11,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/gorilla/websocket" | |||
| "github.com/samsarahq/go/oops" | |||
There was a problem hiding this comment.
Is this a new dependency?
Pull Request Test Coverage Report for Build 1147
💛 - Coveralls |
berfarah
approved these changes
Oct 10, 2018
|
Think we can revisit if/when go2 takes a stance. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful for debugging c.handle errors logged. As a follow up, we should
fix up this code path so that errors can be handled by the client code.