Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GVRCameraRig::setCameraRigType(int) - Invalid parameter #26

Closed
nathanalmeida opened this issue Apr 17, 2015 · 2 comments
Closed

GVRCameraRig::setCameraRigType(int) - Invalid parameter #26

nathanalmeida opened this issue Apr 17, 2015 · 2 comments
Assignees
Labels

Comments

@nathanalmeida
Copy link
Contributor

There could be an IllegalArgumentException message for passing an invalid cameraRigType to GVRCameraRig::setCameraRigType().

public void testExpectedAnIllegalArgumentException() {
        try {
            GVRCameraRig gvrCameraRig = TestDefaultGVRViewManager.mGVRContext.getMainScene().getMainCameraRig();
            gvrCameraRig.setCameraRigType(404);
            fail();
        } catch (IllegalArgumentException e) {
            assertEquals(e.getMessage(), "IllegalArgumentException for cameraRigType. Types supported: " +
                    "GVRCameraRig.GVRCameraRigType.Free, " +
                    "GVRCameraRig.GVRCameraRigType.Freeze, " +
                    "GVRCameraRig.GVRCameraRigType.OrbitPivot" +
                    "GVRCameraRig.GVRCameraRigType.RollFreeze" +
                    "GVRCameraRig.GVRCameraRigType.YawOnly");
        }
}
@JonShemitz
Copy link
Contributor

Yes. Low priority, imho.

@jason2kim jason2kim assigned thomasflynn and unassigned jason2kim May 7, 2015
danke-sra pushed a commit to danke-sra/GearVRf that referenced this issue Oct 30, 2015
(b19088) Limit # of threads in gvrf
@liaxim
Copy link
Contributor

liaxim commented Nov 8, 2017

Planning to close as obsolete in a day or two

@liaxim liaxim closed this as completed Nov 9, 2017
liaxim pushed a commit to liaxim/GearVRf that referenced this issue Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants