Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic elements in getting started #19

Open
AdaRoseCannon opened this issue Dec 4, 2019 · 1 comment
Open

Semantic elements in getting started #19

AdaRoseCannon opened this issue Dec 4, 2019 · 1 comment

Comments

@AdaRoseCannon
Copy link
Contributor

In https://oneuiweb.dev/#/getting-started/quickstart
the markup is:

    <main class="container">
      <div class="viewing">
          <!-- Viewing area -->
      </div>
      <div class="content">
          <!-- Interaction area -->
      </div>
    </main>

I think probably think <div class="viewing"> should maybe be a <section> or a <header> and <div class="content"> should be a <section> or an <article>
@PicchiKevin
Copy link
Collaborator

Agree, planning to follow this: https://www.w3.org/TR/wai-aria-practices/examples/landmarks/HTML5.html
so it would look something like this:

<html lang="en">
    <head>
       ...
    </head>
    <body>
        <header>This is the header</header>
        <nav>This is the nav</nav>
        <main>And here is main</main>
    </body>
</html>

PR are welcome 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdaRoseCannon @PicchiKevin