the disk backed queue should set "canAdd" to false whenever we have #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh13
force-pushed
the
nh_fix_picard_issue_327
branch
2 times, most recently
from
b2ba52e
to
f3c561c
Compare
nh13
force-pushed
the
nh_fix_picard_issue_327
branch
from
f3c561c
to
0368f16
Compare
tfenne
force-pushed
the
nh_fix_picard_issue_327
branch
2 times, most recently
from
2398c83
to
2cbd55a
Compare
spilled to disk and have started removing records from RAM, or whenever we start removing records from disk. The pathology was that we would let callers add if there was any room in ram, regardless if we had spilled records to disk, thus causing records to become out of order. If the entire queue is empty, we set canAdd to true again. Added test to make sure an exception is thrown if we add when we should not.
tfenne
force-pushed
the
nh_fix_picard_issue_327
branch
from
2cbd55a
to
cca683c
Compare
|
OMFG the statefulness in these tests is really sucky. Think I've finally got it this time. 🔨 |
|
@nh13 I reviewed the code and the new test and think this looks good. I also fixed up the failing test (it was a nasty interdependency between test classes and tmp directory contents, not a problem with the code being tested). Merging now. |
tfenne
added a commit
that referenced
this pull request
Nov 24, 2015
the disk backed queue should set "canAdd" to false whenever we have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spilled to disk and have started removing records from RAM, or whenever
we start removing records from disk. The pathology was that we would
let callers add if there was any room in ram, regardless if we had
spilled records to disk, thus causing records to become out of order.
If the entire queue is empty, we set canAdd to true again. Added test
to make sure an exception is thrown if we add when we should not.
See: broadinstitute/picard#327
@bradtaylor