Variable name used by dlsym in load_plugin corrected. #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hfile irods plugin depends on a constructed symbol name which was no longer being used.
|
Alas, this was a cut'n'pasto in 00c61d2. /me hangs head in shame. Feel free to be more explicit in the commit message: Fortunately this only affects the minority of plugins needing Sigh… all that conversation on #1072 and neither I nor anyone else reviewed this line carefully enough to catch this inadvertent change… 😞 |
jmarshall
pushed a commit
to jmarshall/pysam
that referenced
this pull request
Oct 20, 2020
Apply PR samtools/htslib#1150. The hfile irods plugin depends on a constructed symbol name which was no longer being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hfile irods plugin depends on a constructed symbol name which was no longer being used. This is a small fix to changes made in #1072.