Fix duplicated but missing FORMAT bug #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ce510c added code to drop duplicate FORMAT tags, but missed the case where the duplicated entry was off the end of the per-sample data, so it hit the part that put in MISSING values. This lead to an attempt to call memset() with a negative size. Fixed by adding code to skip the duplicated FORMAT tag. Credit to OSS-Fuzz Fixes oss-fuzz 67431
pd3
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7ce510c added code to drop duplicate FORMAT tags, but missed the case where the duplicated entry was off the end of the per-sample data, so it hit the part that put in MISSING values. This lead to an attempt to call memset() with a negative size. Fixed by adding code to skip the duplicated FORMAT tag.