Logging improvements 3 #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded missing dependencies to the Makefile, including the missing definition of htslib_hts_h.
They're not missing — they come from htslib_vars.mk. |
|
Thanks for the update. I've fixed the dependency to use the variable from htslib_vars.mk and will merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced another batch of fprintf(stderr, ...) calls with hts_log_... calls, this time aiming to cover everything except the CRAM code.
Also fixed some missing header file dependencies in the Makefile that I happened to find.
This is the third pull request in a series that aims to solve #403 .