Silence gcc warnings #973
Merged
Silence gcc warnings #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some optimisation levels, gcc would report a format-truncation warning for the line that measured how much memory was needed to store the header string. Silence it by supplying a reasonably big buffer, which has the added bonus that the malloc and second call to vsnprintf can be avoided completely in most cases.
Silence 'end' may be used uninitialized warning from gcc 4 by making it more obvious that EOF is returned when 'start' is NULL (and 'end' is not used in that case).
|
@pd3 reported another warning from gcc version 4. It looks like a false positive, but it's trivial to fix so I've added a commit to make it go away. |
daviesrob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some optimisation levels, gcc would report a format-truncation warning for the line that measured how much memory was needed to store the header string. Silence it by supplying a reasonably big buffer, which has the added bonus that the malloc and second call to vsnprintf can be avoided completely in most cases.