Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot_Density_Custom custom_palette option only applies the custom palette to last plot if passed multiple genes #53

Closed
jdparker101 opened this issue Aug 12, 2022 · 2 comments

Comments

@jdparker101
Copy link

Hi, first of all, thanks for making the excellent package, it has been extremely helpful. However, I have a suggestion for an improvement. You can pass multiple genes to the nebulosa function plot_density and likewise your custom function that uses plot_density, Plot_Custom_Density in order to make a nice figure panel of nebulosa figures. However, when you pass multiple genes to Plot_Custom_Density with the custom_palette option set to your own bespoke color scheme, the colors are only applied to the last plot. Perhaps there is a way around this to get it to apply to all the plots I am not aware of, but if not, it would be a helpful amendment.

@samuel-marsh
Copy link
Owner

Hi,

Thanks for kind words!! That’s good catch. I’ll take look over weekend but believe it’s simple fix and I can push fix early next week to the develop branch.

Thanks!
Sam

@samuel-marsh
Copy link
Owner

Hi,

Sorry for the delay here. The fix is now available of the develop branch v0.7.0.9934. If you run into any issues still please comment here and I'll reopen issue.

Best,
Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants