-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jobs timeout #248
Fix jobs timeout #248
Conversation
sorry, looks like tests are failing. |
I think it's not tests but some issue with codecove: https://about.codecov.io/security-update/ UPD: on py3.6 test indeed is failing, I will have a look. |
Should be fixed now. |
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 99.78% 99.78% -0.01%
==========================================
Files 11 11
Lines 937 935 -2
Branches 133 133
==========================================
- Hits 935 933 -2
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
thanks for this, and sorry it's taken so long to get merged. I'm going to try and get support for aioredis 2 (#259) fixed, then create a new release. |
* Fix jobs timeout python-arq#247 * Bump codecov-action to v1.5.2 * Fix test Co-authored-by: Kirill Matveev <kirill.matveev@akvelon.com>
Currently on job timeout there is log message:
job_name cancelled, will be run again
and job is restarted immediately.This PR fixes it:
TimeoutError
is logged and job is not restarted. (see #247)