Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jobs timeout #248

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Fix jobs timeout #248

merged 3 commits into from
Sep 2, 2021

Conversation

kiriusm2
Copy link
Contributor

@kiriusm2 kiriusm2 commented May 16, 2021

Currently on job timeout there is log message: job_name cancelled, will be run again and job is restarted immediately.
This PR fixes it: TimeoutError is logged and job is not restarted. (see #247)

@samuelcolvin
Copy link
Member

sorry, looks like tests are failing.

@kiriusm2
Copy link
Contributor Author

kiriusm2 commented Jun 2, 2021

sorry, looks like tests are failing.

Screenshot from 2021-06-02 22-54-59

I think it's not tests but some issue with codecove: https://about.codecov.io/security-update/

UPD: on py3.6 test indeed is failing, I will have a look.

@kiriusm2
Copy link
Contributor Author

sorry, looks like tests are failing.

Should be fixed now.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #248 (4461aa1) into master (8ee04f9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   99.78%   99.78%   -0.01%     
==========================================
  Files          11       11              
  Lines         937      935       -2     
  Branches      133      133              
==========================================
- Hits          935      933       -2     
  Misses          1        1              
  Partials        1        1              
Impacted Files Coverage Δ
arq/worker.py 99.55% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee04f9...4461aa1. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 1fb9842 into python-arq:master Sep 2, 2021
@samuelcolvin
Copy link
Member

thanks for this, and sorry it's taken so long to get merged.

I'm going to try and get support for aioredis 2 (#259) fixed, then create a new release.

isobelhooper pushed a commit to CQCL-DEV/arq that referenced this pull request May 4, 2022
* Fix jobs timeout python-arq#247

* Bump codecov-action to v1.5.2

* Fix test

Co-authored-by: Kirill Matveev <kirill.matveev@akvelon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants