Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionController::TestCase needs keyword args #905

Closed
atz opened this issue Aug 16, 2016 · 0 comments · Fixed by #911
Closed

ActionController::TestCase needs keyword args #905

atz opened this issue Aug 16, 2016 · 0 comments · Fixed by #911
Assignees
@atz

Comments

@atz
Copy link
Contributor

atz commented Aug 16, 2016 

DEPRECATION WARNING: ActionController::TestCase HTTP request methods will accept only
keyword arguments in future Rails versions.

Examples:

get :show, params: { id: 1 }, session: { user_id: 1 }
process :update, method: :post, params: { id: 1 }

Occurs hundreds of times in test suite.
atz added a commit that referenced this issue Aug 17, 2016
@atz
Use params keyword with ActionController::TestCase
9e73eb0 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
@atz atz mentioned this issue Aug 17, 2016
Merged
@atz atz self-assigned this Aug 17, 2016
atz added a commit that referenced this issue Aug 17, 2016
@atz
Use params keyword with ActionController::TestCase
c157b52 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 17, 2016
@atz
Use params keyword with ActionController::TestCase
370b7f8 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 17, 2016
@atz
Use params keyword with ActionController::TestCase
2f0c5a3 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 17, 2016
@atz
Use params keyword with ActionController::TestCase
4019edb 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 17, 2016
@atz
Use params keyword with ActionController::TestCase
da62955 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 17, 2016
@atz
Use params keyword with ActionController::TestCase
3b85e98 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 18, 2016
@atz
Use params keyword with ActionController::TestCase
3c68fe5 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 18, 2016
@atz
Use params keyword with ActionController::TestCase
0274ac3 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 18, 2016
@atz
Use params keyword with ActionController::TestCase
8d8d763 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
atz added a commit that referenced this issue Aug 18, 2016
@atz
Use params keyword with ActionController::TestCase
e269cf9 
Largely fixes #905.  Remaining warnings are from a helper class.

Saves hundreds of lines of deprecation warnings per CI run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atz atz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use params keyword with ActionController::TestCase samvera-deprecated/curation_concerns
2 participants
@jcoyne @atz