Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flash message is not appropriate after work save #2104

Closed
carolyncole opened this issue May 31, 2016 · 7 comments
Closed

flash message is not appropriate after work save #2104

carolyncole opened this issue May 31, 2016 · 7 comments
Assignees
Milestone

Comments

@carolyncole
Copy link
Contributor

carolyncole commented May 31, 2016

Descriptive summary

In Sufia 7.0 after you save a work you go to the work show page. You then see a message about refreshing your dashboard.

Expected behavior

Message should say "You may need to refresh this page to see the changes you made" rather than mentioning the dashboard.

Actual behavior

screen shot 2016-05-31 at 7 36 44 am

Steps to reproduce the behavior

  1. Click on new work
  2. Fill in Metadata
  3. Choose a file
  4. Click on accept
  5. Click on Save
  6. The flash message is shown at the top of the page
@atz
Copy link
Contributor

atz commented May 31, 2016

Would we accept "you may need to refresh"?

@mjgiarlo
Copy link
Member

I'm partial to 'You may need to refresh your browser.'

Tagging @projecthydra/sufia-ui-ux-advisors for their input.

@atz
Copy link
Contributor

atz commented May 31, 2016

The flash messages are good candidates for extraction into a template or translations file, also. Currently duplicated in batch_uploads_controller_behavior.rb and works_controller_behavior.rb.

@newmanld
Copy link

To avoid someone thinking this means upgrade the browser (although this would of course be over-literal), how about
‘You may need to refresh this page in your browser.’

Or does ‘reload’ come across better than ‘refresh’?

If I mouse over the button in Chrome (Windows & Mac), it says ‘Reload this page’. In Firefox (Windows & Mac), ‘Reload current page’. In IE (Windows)‘Refresh’. In Safari (Mac)‘Reload the current page’.

Looked for expert guidance on the web and didn’t find it.

@heidisb
Copy link

heidisb commented Jun 1, 2016

I'm partial to refresh. It feels like the more common vernacular, but I don't have any proof (other than Googling 'reload browser' and getting a lot of results with 'refresh' in it).

I do agree with @newmanld about specifying page instead of (or in addition to) browser. In my past reference librarian life...it was shocking how many people did not know what a browser is even though they were using one.

My recommendation is: You may need to refresh this page...

@bnhowell
Copy link

bnhowell commented Jun 1, 2016

+1 for: "You may need to refresh this page..."

On Wed, Jun 1, 2016 at 9:01 AM, Heidi Burkhardt notifications@github.com
wrote:

I'm partial to refresh. It feels like the more common vernacular, but I
don't have any proof (other than Googling 'reload browser' and getting a
lot of results with 'refresh' in it).

I do agree with @newmanld https://github.com/newmanld about specifying
page instead of (or in addition to) browser. In my past reference librarian
life...it was shocking how many people did not know what a browser is even
though they were using one.

My recommendation is: You may need to refresh this page...


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#2104 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AQBqv6i2i0s-k-cZe3u2jZEJSQibx2UIks5qHYKmgaJpZM4IqcQa
.

Ben Howell | Accessibility & User Experience Specialist
Design & Discovery | LIT | University of Michigan Library
bnhowell@gmail.com

@mjgiarlo
Copy link
Member

mjgiarlo commented Jun 1, 2016

Sounds like consensus to me. Thanks, all! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants