Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flash message after work is created, fixes #2104 #2191

Merged
merged 1 commit into from
Jun 10, 2016

Conversation

awead
Copy link
Contributor

@awead awead commented Jun 10, 2016

Fixes #2104

Updates the flash message and puts the content under i18n for better management.

@projecthydra/sufia-code-reviewers

@@ -208,6 +208,7 @@ en:
new:
header: Add New Work
in_collections: This Work in Collections
after_create_response: "Your files are being processed by %{application_name} in the background. The metadata and access controls you specified are being applied. Files will be marked <span class=\"label label-danger\" title=\"Private\">Private</span> until this process is complete (shouldn't take too long, hang in there!). You may need to refresh this page to see these updates."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be after_create_response_html since there are html tags in there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wondered about that too, but it renders fine.

@awead
Copy link
Contributor Author

awead commented Jun 10, 2016

@jcoyne updated. _html is used with all the other ones, so it'll be consistent now.

@jcoyne jcoyne merged commit a1be81d into master Jun 10, 2016
@jcoyne jcoyne deleted the after-create-message branch June 10, 2016 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants