Allow limiting returned results to xsd:string #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
string_results_only
branch
2 times, most recently
from
3135360
to
5857992
Compare
elrayle
commented
May 11, 2019
| graph << [object, RDF::Vocab::DC.title, "Hello, world!"] | ||
| graph << [object, RDF::Vocab::DC.title, b1] |
There was a problem hiding this comment.
Adding in a blank node to the title because there needs to be something other than string for test differentiation.
elrayle
force-pushed
the
string_results_only
branch
from
5857992
to
9d40709
Compare
elrayle
force-pushed
the
string_results_only
branch
from
14f3b72
to
8e2dd5a
Compare
jcoyne
reviewed
Nov 4, 2021
| uri if (uri.has_datatype? && uri.datatype == type) || (uri.plain? && string_type?(type)) | ||
| end | ||
|
|
||
| def string_type? type |
There was a problem hiding this comment.
Should this be a private method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby-rdf/rdf Literal#has_datatype? specifically ignores Literals of the xsd:string type. The #plain method checks for string type. So that can be used to check if this is a string and also compare datatype to type if it is. This allows for limiting returned results to strings.
I suspect that the default type is xsd:string. So this may allow more matches than is desired. But without this test change, there are 0 matches when filtering for xsd:string.
I added an issue to ruby-rdf/rdf to ask about the reason for excluding xsd:string. See issue ruby-rdf/rdf#396 for more information.