Improve timerail highlight #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjarling
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player highlighting the structure in the time rail with structure navigation and seek/scrub events:
Screencast.from.02-25-2021.11_21_16.AM.1.mp4
Timerail highlight updating with
timeupdateevent fromvideo.js:(First the existing timerail highlight is removed when the time reaches the end of that media fragment (around 06:13). From 06:13-08:45 there is no defined structure, so there's no timerail highlight. And then when time reaches 08:45 the highlight is created for the media fragment starting from 08:45 timestamp)
Screencast.from.03-11-2021.09_19_33.AM.mp4