Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.0.3 #1470

Closed
jrgriffiniii opened this issue Mar 1, 2022 · 12 comments
Closed

Support Ruby 3.0.3 #1470

jrgriffiniii opened this issue Mar 1, 2022 · 12 comments
Assignees

Comments

@jrgriffiniii
Copy link
Contributor

This is derived from samvera/maintenance#77

@jrgriffiniii jrgriffiniii self-assigned this Mar 1, 2022
@jrgriffiniii jrgriffiniii changed the title Support Ruby 3.0.3 releases Support Ruby 3.0.3 Mar 1, 2022
@jrgriffiniii
Copy link
Contributor Author

49c0f0d finally ensures that bundle install can reliably install Gem dependencies, however the following psych bug is now raised:

An error occurred while loading ./spec/integration/associations_spec.rb.
Failure/Error: fedora_yml = YAML.safe_load(config_erb, [], [], true) # allow YAML aliases

ArgumentError:
  wrong number of arguments (given 4, expected 1)
# ./vendor/bundle/gems/psych-4.0.3/lib/psych.rb:323:in `safe_load'
# ./lib/active_fedora/file_configurator.rb:111:in `load_fedora_config'

@jrgriffiniii
Copy link
Contributor Author

For releases of ldp following 0.4.1, Ruby 2.y.z releases are required (please compare https://rubygems.org/gems/ldp/versions/0.4.1 and https://rubygems.org/gems/ldp/versions/0.5.0)

@jrgriffiniii
Copy link
Contributor Author

@jrgriffiniii
Copy link
Contributor Author

This is also blocked by another release of ldp:

active-fedora was resolved to 13.2.7, which depends on
      ldp (>= 1.0) was resolved to 1.0.3, which depends on
        Ruby (~> 2.0)

@jrgriffiniii
Copy link
Contributor Author

55ef06e seems to still be blocked until I can port Lando for running the test suites.

@jrgriffiniii
Copy link
Contributor Author

https://github.com/samvera/active_fedora/compare/updating-active-triples?expand=1 advances this with as much labor as I can provide before the next scheduled Developer Congress.

@jrgriffiniii
Copy link
Contributor Author

POST requests are submitted with erroneously-formatted parameters:

"\n [info:fedora/fedora-system:def/model#hasModel "Image"] .\n

These brackets should not be present here.

@jrgriffiniii
Copy link
Contributor Author

c53f863 ensures that nodes for ordered list nodes can be resolved from LDP servers.

@jrgriffiniii
Copy link
Contributor Author

4029315 was needed as a starting point for me to understand why Proxy models are not being resolved from ListSources when ActiveFedora::Base#reload is invoked (they are persisted, but for some reason, the cache for these is not repopulated for the Associations).

@jrgriffiniii
Copy link
Contributor Author

e629829 is a potential solution, but I am still struggling to understand why this was breaking with a simple Ruby/Rails upgrade.

@jrgriffiniii
Copy link
Contributor Author

49c1203 was needed to address certain cases where duplication was occurring, but this does not seem to correctly address the cases for ordering elsewhere.

@cjcolvar
Copy link
Member

cjcolvar commented Jan 11, 2023

Draft PR: #1489 waiting on ActiveTriples support for ruby 3.

@jrgriffiniii jrgriffiniii self-assigned this Jan 13, 2023
@cjcolvar cjcolvar closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants