Setting the download directory so you only get one instance downloaded…

[carolyncole]

per machine. fixes #1080

[jcoyne]

I wonder if these should be <%= ENV['TMPDIR'] %>? @cbeer ?

[cbeer]

That'd certainly be better (and cross platform..)... although isn't this the same as the default behavior upstream?

[mjgiarlo]

<%= ENV.fetch('TMPDIR', '/tmp') %> ?

[jcoyne]

@cbeer Yes, that is curious. Why is it downloading then?

[jcoyne]

@Cam156 are you sure this fixes the issue?

Prior to using this change I see:

require 'solr_wrapper'
=> true
irb(main):002:0> SolrWrapper.instance(config: 'config/solr_wrapper_test.yml').config.instance_dir
=> "tmp/solr-test"
irb(main):003:0> SolrWrapper.instance(config: 'config/solr_wrapper_test.yml').config.download_dir
=> "/var/folders/9t/rygbnddx0b1ckw6tjs3m18qm0000gq/T"

So it appears as though it's already looking in the tmp directory for the download_dir.

[carolyncole]

@jcoyne looking at the default here: https://github.com/cbeer/solr_wrapper/blob/master/lib/solr_wrapper/configuration.rb#L58-L60
If you are in a rails app it uses tmp instead of /tmp
So depending on where you run the wrapper it behaves differently. So I am not 100% sure, but I would believe it to work...

[jcoyne]

@Cam156 Yes, I see that. I wonder if it makes more sense to just remove that logic from solr_wrapper?

[carolyncole]

@jcoyne I would be ok with that approach.

[mjgiarlo]

@Cam156 @jcoyne so am I hearing that this will be fixed in solr_wrapper, and no related change is needed in AF? or?

[jcoyne]

I think this should get fixed in solr_wrapper. It's a broader issue than just AF.

[mjgiarlo]

OK. @Cam156 should we close this issue?

[carolyncole]

@mjgiarlo Is there an issue on Solr wrapper? I would leave it open until there is...

[mjgiarlo]

@Cam156 There are 0 open issues on solr_wrapper, so no.