-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the download directory so you only get one instance downloaded… #1081
Conversation
@@ -2,3 +2,4 @@ | |||
port: 8984 | |||
enable_jms: false | |||
fcrepo_home_dir: tmp/fcrepo4-development-data | |||
download_dir: /tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if these should be <%= ENV['TMPDIR'] %>
? @cbeer ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd certainly be better (and cross platform..)... although isn't this the same as the default behavior upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<%= ENV.fetch('TMPDIR', '/tmp') %>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbeer Yes, that is curious. Why is it downloading then?
@Cam156 are you sure this fixes the issue? Prior to using this change I see:
So it appears as though it's already looking in the tmp directory for the download_dir. |
@jcoyne looking at the default here: https://github.com/cbeer/solr_wrapper/blob/master/lib/solr_wrapper/configuration.rb#L58-L60 |
@Cam156 Yes, I see that. I wonder if it makes more sense to just remove that logic from solr_wrapper? |
@jcoyne I would be ok with that approach. |
I think this should get fixed in solr_wrapper. It's a broader issue than just AF. |
OK. @Cam156 should we close this issue? |
@mjgiarlo Is there an issue on Solr wrapper? I would leave it open until there is... |
@Cam156 There are 0 open issues on solr_wrapper, so no. |
per machine. fixes #1080