Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impove German translation. #1557

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Impove German translation. #1557

merged 2 commits into from
Oct 25, 2018

Conversation

jmfrenzel
Copy link
Contributor

Fixes #1552 #1551

Changes proposed in this pull request:

  • improving German language (native speaker)

@samvera/hyrax-code-reviewers

jcoyne
jcoyne previously approved these changes Oct 23, 2018
View reviewed changes
orangewolf
orangewolf approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updated translations, looks like we're seeing some spec failures, but I don't think they are actually related to this work. I'm going to merge and then fix anything that's actually broken in master

@orangewolf orangewolf merged commit 1a82892 into samvera:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangewolf orangewolf orangewolf approved these changes

@jcoyne jcoyne jcoyne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmfrenzel @jcoyne @orangewolf