Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Honeybadger Gem #1669

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Remove Honeybadger Gem #1669

merged 1 commit into from
Mar 22, 2021

Conversation

prdanelli
Copy link
Contributor

This might be a little forward of me however the Gem causes an almost intolerable amount of log noise when used with Ruby 2.7.x.

> docker-compose exec web bundle exec rails console
# ...
Hyrax::Engine.after_initialize - persisting registered roles!
** [Honeybadger] Initializing Honeybadger Error Tracker for Ruby. Ship it! version=3.3.1 framework=rails level=1 pid=45
** [Honeybadger] Development mode is enabled. Data will not be reported until you deploy your app. level=2 pid=45
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:65: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/usr/local/bundle/gems/honeybadger-3.3.1/lib/honeybadger/plugin.rb:69: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
Loading development environment (Rails 5.2.4.5)
irb: warn: can't alias context from irb_context.
irb(main):001:0>

It doesn't seem that the Gem is extensively used around the application and rom my foray round the codebase it seems that the Gem version was last updated about 4 years ago in the following commit:

918ccae

I realise this might be controvertial, however if an organisation needs Honeybadger, wouldn't they also likely require a version less than 4 years old and if so, would likely be able to install it themselves.

@prdanelli
Copy link
Contributor Author

@orangewolf I've been asked to ping you on this one too as you might be interested.

@orangewolf
Copy link
Member

@prdanelli this works for me. I'd ultimately like to set up a library that lets you swap your choice of exception handler (something like ActiveJob or ActiveRecord, but for exceptions). Since that doesn't exist as far as I can tell, at least pulling out this very specific vendor choice seems like the right thing to me.

@orangewolf orangewolf merged commit 5e77552 into samvera:master Mar 22, 2021
@no-reply
Copy link

+1 to this, in general.

but also, note that the chatty Ruby 2.7 deprecation notices were silenced in Ruby 2.7.2 (see: https://bugs.ruby-lang.org/issues/17000). Hyrax turns them off in the test suite with: $VERBOSE = nil.

prdanelli added a commit to ubiquitypress/hyku that referenced this pull request Mar 24, 2021
orangewolf pushed a commit that referenced this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants