Works deposited via proxy are always set to private visibility

[rjkati]

Descriptive summary

On nurax-pg, when depositing a work as a proxy, the visibility of the work is set to private even if the visibility on deposit was set to public.

Expected behavior

Works deposited via proxy should reflect the visibility settings selected during the deposit process.

Actual behavior

Works deposited via proxy are set to private.

Steps to reproduce the behavior

1. Make sure that proxy deposit is enabled on nurax-pg and that you have an account set up as a proxy for another account
2. Navigate to Dashboard -> Works
3. Click "Add new work" and select "Generic Work"
4. Fill out required metadata and add a file
5. Select "Public" visibility
6. Select another user in the "Proxy depositors" box.
7. Check the Deposit agreement box and click "Save".
8. Observe message "Unauthorized The page you have tried to access is private" message

[hackartisan]

There's definitely a race condition here somewhere. With breakpoints in the ContentDepositorChangeEventJob and in the SetDefaultAdminSet transaction the bug disappears.

Could

hyrax/config/initializers/listeners.rb

Line 19 in 10d4c2e

Hyrax.publisher.publish('object.deposited', object: curation_concern, user: user)

be relevant? The pub/sub architecture seems like it could also be prone to race conditions. Probably the behavior should be moved into a transaction.

[hackartisan]

It looks like visibility is not defined as an attribute on the resource. So when the postgres adapter saves it by pulling its attributes it simply doesn't come out and doesn't override the old value.

Edit to add: that's a red herring, visibility is determined by logic outside the simple existence of a property.