Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depositors (proxies, transfers) synchronously #5553

Merged
merged 10 commits into from Mar 18, 2022

Conversation

hackartisan
Copy link
Contributor

supercedes #5537
follow-up to #5529 and #5550
closes #5457

Deprecates ContentDepositorChangeEventJob which called ChangeContentDepositorService, replacing them with a service that does the work and then backgrounds the event logging.

Follow-on work will move file set updates to a new background job, since there might be a lot of file sets. Issue to be created, linked here.

@hackartisan
Copy link
Contributor Author

This should be in draft until #5550 is merged and rebased on that PR.

Copy link
Contributor

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. There is a lot in this PR and I appreciate all the time it took to get this right.

There is a request for one new test and a question about the order of steps for work_create transaction.

lib/hyrax/transactions/work_create.rb Show resolved Hide resolved
@hackartisan hackartisan marked this pull request as ready for review March 18, 2022 20:02
@hackartisan hackartisan force-pushed the 5457-fix-proxy-deposit-with-deprecations branch from 156f2a5 to 5aa3758 Compare March 18, 2022 20:02
Copy link
Contributor

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reordering the work_create steps and getting in the test. This was quite a slog, but well done.

@elrayle elrayle merged commit d628b58 into main Mar 18, 2022
@elrayle elrayle deleted the 5457-fix-proxy-deposit-with-deprecations branch March 18, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Works deposited via proxy are always set to private visibility
2 participants