Remove proxy deposit listener, use transfer request actor #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
force-pushed
the
5457-revert-proxy-deposit-listener
branch
from
084a7f6
to
e82bed0
Compare
Essentially reverts #4653. The listener appears to be failing to run correctly due to race conditions observed when investigating #5457 and a similar bug that appeared after an upgrade to hyrax 3.2 at Duke. The actor is un-deprecated here because the full actor stack will be deprecated once it's been replaced by the valkyrie transactions code path. Advances #5457; addition of a transaction step in a forthcoming PR.
hackartisan
force-pushed
the
5457-revert-proxy-deposit-listener
branch
from
e82bed0
to
93118ed
Compare
elrayle
approved these changes
Mar 16, 2022
This was referenced Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially reverts #4653.
The listener appears to be failing to run correctly due to race
conditions observed when investigating #5457 and a similar bug that
appeared after an upgrade to hyrax 3.2 at Duke.
The actor is un-deprecated here because the
full actor stack will be deprecated once it's been replaced by the
valkyrie transactions code path.
Advances #5457; addition of a transaction step in a forthcoming PR.