Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of File Edit page #942

Open
ggeisler opened this issue May 10, 2017 · 2 comments
Open

Improve design of File Edit page #942

ggeisler opened this issue May 10, 2017 · 2 comments

Comments

@ggeisler
Copy link
Contributor

ggeisler commented May 10, 2017

The approach to this page, especially the Permissions tab, Share With section, doesn't align well with other aspects of Hyrax and Hyku. Some issues to be addressed in an improved design:

  • Move Share With section to a separate tab, called "Share"
  • Rename current tab to "Visibility"
  • For the Share section/tab, consider discarding virtually all of the explanatory text, which we don't use in other places where the user is making similar sharing decisions
  • For the Share section/tab, update the presentation to more closely resemble the Participants tab of Admin Sets

Design mockups TBD.

@mjgiarlo mjgiarlo modified the milestone: Backlog May 15, 2017
@hannahfrost
Copy link

@ggeisler Here is the older ticket with File Edit page changes needed: samvera/hyku#499

@ggeisler ggeisler changed the title Improve design of File Edit page, Permissions tab Improve design of File Edit page Jul 6, 2017
@ggeisler
Copy link
Contributor Author

ggeisler commented Jul 6, 2017

Mockups below.

Suggested changes that apply to all tabbed pages:

  • Remove icons from tabs
  • Remove image and "Download image" link. There are more obvious places in the application for the owner/manger of a file to see or download it than when editing it. The user most likely arrives at this edit page from a page where the subject file was shown and is unlikely to need a visual reminder of what file it is she is editing. It's appropriate for a show page but not an edit page.
  • Remove redundant tabbed page headings that are already expressed as the tab title. If they are there for accessibility purposes it seems like they could be given a "screen-reader-only" class to serve that purpose?
  • Add link to return to Work, if that is how the user arrived at this page. See note in the Description tab mockup.

Description tab

  • Change field label to "Filename" (as suggested in Tweaks to file descriptions panel hyku#499)
  • Singularize tab title (this came up when discussing the Work tab titles and I think a reasonable argument was made for plural "Descriptions" there, but given we have a single field on this page the plural doesn't make sense to me).
  • Update button label

file-edit-description

Versions tab

  • Updated button labels
  • In the list of previous versions, the radio button of the current version should be selected even though the option is disabled (in the current implementation, no radio buttons are selected when arriving at the page). That makes it more clear to the user why the current version is disabled; because it is the version already active.

file-edit-versions

Visibility tab

file-edit-visibility

Sharing tab

This is a new tab, conveying the goal of the "Share With" section in the currently implemented "Permissions" tab. The content and layout is much different than what currently exists. This is a result of 1) eliminating unnecessary explanatory text, and 2) using a sharing permissions structure that is more closely aligned with how we now expose sharing options elsewhere in the application.

file-edit-sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants