[WIP] Deprecate Hyrax's Noid functionality

[jcoyne]

NOID has been the favored ID generator since Sufia's early days. But there are some issues with NOID:

1. It may be faster and less error prone to use the default Fedora UUIDs.
2. Some institutions may favor their own service for generating identifiers.
3. Adding another mandatory dependency slows the build.

Deprecating NOID integration will enable us to address these issues.

NOTE If you were using noids, you must now explicitly turn them on: config.enable_noids = true. Previously this was the default.

[mjgiarlo]

Please leave this PR open until we've had a chance to discuss the ramifications on the May 31st community tech call. Thanks!

[jcoyne]

I'm not sure how to get these tests to run. Travis says: "The repository at projecthydra-labs/hyrax was not found."

[mjgiarlo]

@jcoyne have you tried pushing a change to the branch?

[jcoyne]

This block tests the same stuff as the block starting at line 222

[escowles]

I see reasons to make using Fedora's UUIDs the default (faster, less error prone, etc.) — but I don't see any reason for deprecating NOIDs. I've heard tell of errors minting NOIDs at scale, but have never seen these personally.

[jcoyne]

@escowles It does not deprecate the use of noids, It just deprecates the tight coupling between hyrax and AF-noid. You can still use AF noid by including ActiveFedora::Noid::Model on your model classes.

[hackartisan]

Link to background discussion on this change? I would expect implications for the maintenance and stability of the NOID codebase over time.

[jcoyne]

@HackMasterA I'm not sure I understand this statement:

I would expect implications for the maintenance and stability of the NOID codebase over time.

The only way I can see decoupling components would affect maintenance is that people who are not using those components would not be involved in their maintenance. That seems fair, right?

I'm not sure how stability would be affected in any way.

[jcoyne]

@HackMasterA I don't think there has been any prior discussion. In hyku we had to stop using AF-noid because it was a bottleneck on large imports.

[hackartisan]

Can you say more about what you observed with hyku?

[mjgiarlo]

We'll be discussing on the Tech call momentarily, for folks who can dial in.

[mjgiarlo]

We decided not to move forward with deprecating NOID usage in Hyrax given the community's desire to keep using NOIDs.

[atz]

@mjgiarlo so we close this?

[jcoyne]

@atz please don't. The feedback from this meeting was that certain parts of the PR were acceptable, but outright deprecation was not. So I'd like to rework it when I come back to Hyrax at some point.

[jcoyne]

Working on an approach to this in:
samvera/active_fedora#1295

Which will require:
samvera/hydra-head#425
And:
#2256

[jenlindner]

Where are things at with this? samvera/hydra-head#425 was merged, #2256 had been blocked by two pulls that have been merged. Looks like only samvera/active_fedora#1295 is left, where there's an open question but no opposition, it seems?

[cjcolvar]

@no-reply @vantuyls This issue has been open for a year. Given that it was decided to not merge this PR as a whole is there a plan to incorporate some of these changes or can this PR be closed?