-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ActiveFedora 12 #425
Conversation
7d47c13
to
56152a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty straightforward, my only question is do we need any documentation on the change from Solrizer to AF::Indexing in the README?
@awead, what was your question on it?
@jenlindner I don't know that we need that documentation here. Solrizer merged into ActiveFedora...so Hydra-Head had to follow suit. |
@@ -80,18 +80,18 @@ def build_agent(name, type) | |||
end | |||
|
|||
def build_agent_resource(prefix, name) | |||
Agent.new(::RDF::URI.new("#{prefix}##{URI.encode(name)}")) | |||
[Agent.new(::RDF::URI.new("#{prefix}##{URI.encode(name)}"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we returning arrays now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because active triples no longer supports scalars. Right @no-reply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason for this is probably: samvera/active_fedora@3c21a7d
Previously, RDF::Term
objects were incorrectly accepted as "multiple" values in ActiveFedora, and this code was likely taking advantage of that bug.
No description provided.