Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ActiveFedora 12 #425

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Allow ActiveFedora 12 #425

merged 1 commit into from
Dec 7, 2017

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Nov 22, 2017

No description provided.

Copy link
Contributor

@jenlindner jenlindner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty straightforward, my only question is do we need any documentation on the change from Solrizer to AF::Indexing in the README?

@awead, what was your question on it?

@jcoyne
Copy link
Member Author

jcoyne commented Nov 30, 2017

@jenlindner I don't know that we need that documentation here. Solrizer merged into ActiveFedora...so Hydra-Head had to follow suit.

@@ -80,18 +80,18 @@ def build_agent(name, type)
end

def build_agent_resource(prefix, name)
Agent.new(::RDF::URI.new("#{prefix}##{URI.encode(name)}"))
[Agent.new(::RDF::URI.new("#{prefix}##{URI.encode(name)}"))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we returning arrays now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because active triples no longer supports scalars. Right @no-reply?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason for this is probably: samvera/active_fedora@3c21a7d

Previously, RDF::Term objects were incorrectly accepted as "multiple" values in ActiveFedora, and this code was likely taking advantage of that bug.

@awead awead merged commit b9f3f17 into master Dec 7, 2017
@awead awead deleted the update_active_fedora branch December 7, 2017 02:00
@awead awead removed the review label Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants