Move email text to locale files

[smithjp]

Fixes #3321

@samvera/hyrax-code-reviewers

[afred]

@smithjp can we parameterize the :en so we're not hardcoding it when calling I18n.with_locale. That will make it easier to change once we have a mechanism for doing so. Thanks!

[smithjp]

Would it make sense to set the locale in a hyrax config variable (in config/initializers/hyrax.rb)?

[jcoyne]

@smithjp no, the language is already set in I18n.locale, please use that.

[jcoyne]

I'm unclear why you need the I18n.with_locale(:en) call at all. Is there some reason not to use the currently set locale?

[smithjp]

The feedback in #3321 indicated that the first step in having emails sent in a particular user's preferred language would be to move the email text to the locale files and always send in english. Further work will need to be done to either have emails sent in an application-wide preferred language or in the recipient's preferred language. Otherwise, emails may be sent based on a depositor's preferred language, which may not be a reviewer's preferred language.

[jcoyne]

@smithjp for now, the system default could be set to :fr, so it would be unexpected to send the emails in :en. You are doing extra work to make it send in :en, but I think just using the default behavior is preferable.

[no-reply]

👍 to using the existing default I18n.t() values and considering that fulfillment of the first step in #3321.

Since that original discussion, I've learned that users already have a preferred_locale. An example usage is here:

hyrax/app/models/user_mailbox.rb

Line 20 in 5a9d1be

I18n.t("hyrax.toolbar.notifications.zero", locale: locale_from_params || preferred_locale)

[no-reply]

This looks like a great step. Thanks!