Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update depositors (proxies, transfers) synchronously #5553

Merged
merged 10 commits into from
Mar 18, 2022
Merged

Update depositors (proxies, transfers) synchronously #5553

merged 10 commits into from
Mar 18, 2022

Commits on Mar 18, 2022

  1. Do proxy deposit updates synchronously 

    Add a new transaction step.
Replace behavior of queuing a job that runs a service with running a
service that then queues a job

closes #5457
    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    f31dbf4 View commit details
    Browse the repository at this point in the history

  2. Copy the job and service to new classes 

    so we can deprecate the old ones
    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    631dbd8 View commit details
    Browse the repository at this point in the history

  3. Restore the job and service so we can deprecate them

    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    1d48f9d View commit details
    Browse the repository at this point in the history

  4. Return the persisted work

    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    212980a View commit details
    Browse the repository at this point in the history

  5. Deprecate the old job and service

    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    8ee1be4 View commit details
    Browse the repository at this point in the history

  6. Use new classes instead of deprecated classes

    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    cc917b4 View commit details
    Browse the repository at this point in the history

  7. Fix specs

    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    5890668 View commit details
    Browse the repository at this point in the history

  8. Address code review

    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    be03876 View commit details
    Browse the repository at this point in the history

  9. Add a nil user guard to the change_depositor transaction step

    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    8370f27 View commit details
    Browse the repository at this point in the history

  10. Ensure files have been added before proxy depositor set. Add a test.

    @hackartisan
    hackartisan committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    5aa3758 View commit details
    Browse the repository at this point in the history