Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Components are tested with supported Ruby/Rails versions #17

Closed
16 of 17 tasks
tpendragon opened this issue Apr 5, 2019 · 4 comments
Closed
16 of 17 tasks
Assignees

Comments

@tpendragon
Copy link
Contributor

tpendragon commented Apr 5, 2019

@jrgriffiniii
Copy link
Contributor

jrgriffiniii commented May 9, 2019

Referencing the notes from the Core Components Maintenance WG meeting held on 03/01/19, attendees determined that the releases of Ruby and Rails which should be supported are those which are still receiving security updates from the community. These would be the following releases at this point in time:

Ruby:

  • 2.6.3
  • 2.5.5
  • 2.4.6

Rails:

  • 5.2.3
  • 5.1.7
  • 5.0.7.2 (please see the comments below)
  • 4.2.11.1 (please see the comments below)

Given that Hyrax (https://github.com/samvera/hyrax/blob/master/.circleci/config.yml), along with some well-maintained Core Components (https://github.com/samvera/valkyrie/blob/master/.circleci/config.yml), are not testing against Rails 4.2.x releases, I'm going to proceed with just trying to introduce this into the test builds.

@cjcolvar
Copy link
Member

cjcolvar commented May 9, 2019

Is the plan to support rails versions that are receiving "security" or "severe security" updates? I asked at the partner's meeting and I thought @mark-dce said only to the "security" level and not "severe security". So that would cut out the 4.2.x series.

@jrgriffiniii
Copy link
Contributor

The tests on Valkyrie were failing for 4.2.x releases without pinning to specific releases of the pg Gem (https://circleci.com/gh/jrgriffiniii/valkyrie/24), so this will definitely assist with reducing the labor involved in component maintenance.

@jrgriffiniii
Copy link
Contributor

samvera/valkyrie#728 (comment) corrects my error, in that both the 5.0.x and 4.2.x series should not be used for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants