-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Components are tested with supported Ruby/Rails versions #17
Comments
Referencing the notes from the Core Components Maintenance WG meeting held on 03/01/19, attendees determined that the releases of Ruby and Rails which should be supported are those which are still receiving security updates from the community. These would be the following releases at this point in time: Ruby:
Rails:
Given that Hyrax (https://github.com/samvera/hyrax/blob/master/.circleci/config.yml), along with some well-maintained Core Components (https://github.com/samvera/valkyrie/blob/master/.circleci/config.yml), are not testing against Rails 4.2.x releases, I'm going to proceed with just trying to introduce this into the test builds. |
Is the plan to support rails versions that are receiving "security" or "severe security" updates? I asked at the partner's meeting and I thought @mark-dce said only to the "security" level and not "severe security". So that would cut out the 4.2.x series. |
The tests on Valkyrie were failing for 4.2.x releases without pinning to specific releases of the |
samvera/valkyrie#728 (comment) corrects my error, in that both the 5.0.x and 4.2.x series should not be used for testing. |
The text was updated successfully, but these errors were encountered: