Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow User-Agent to be set in the constructor #65

Open
tacman opened this issue Jun 3, 2024 · 0 comments
Open

Allow User-Agent to be set in the constructor #65

tacman opened this issue Jun 3, 2024 · 0 comments

Comments

@tacman
Copy link
Contributor

tacman commented Jun 3, 2024

The user-agent default to the php library, but it might be better to be the calling application.

It'd be slightly easier to make that happen in the constructor rather than only via a separate call.

I can submit a PR.

If you do bump the minimum PHP version to only supported PHP, we can add types to many of the properties, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant