Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect code in windows version #8

Open
danthegoodman1 opened this issue Aug 22, 2016 · 1 comment
Open

Incorrect code in windows version #8

danthegoodman1 opened this issue Aug 22, 2016 · 1 comment

Comments

@danthegoodman1
Copy link

On line 37 keyboard should not print app, it should print cmd (or at least that is what it looks like it needs to be, the portions that need to be filled in by the user are not clearly identified in this code which is extremely confusing, especially to someone who may not be very good with code).

Also, line 76 through 84 should be a lot more clear on what should be filled in by the user. (eg line 79: "for /f "tokens=1,2,3*" %%i in ('netsh int show interface') do ("); should not be in the code itself, but the most common one should be put in and then comments on the side should be added for what to do in different situations (unless this is part of the code and I am being very dumb).

The main idea here is that the code should be much more simple to fill in the information that is needed by the user, similar to how Teensyterpreter does it (in a strange way albeit). This code uses almost half the lines and I really want it to be the best it can be (or again, I am just being dumb and thinking about the coding from a different way which I really hope I am not because that would be embarassing).

@spicydll
Copy link

spicydll commented Aug 24, 2016

On line 37 keyboard should not print app, it should print cmd

app on line 37 is a variable. More specifically, a String parameter that represents the app you want to open. This method is used on line 70 to start the Command Prompt. There, it sends the word "cmd" to this method. So actually, the word cmd is printed instead of app.

Also, line 76 through 84 should be a lot more clear on what should be filled in by the user.
...
The main idea here is that the code should be much more simple to fill in the information that is needed by the user

This application does not require any user input, so it doesn't have to be clear. This is meant to be run on an Arduino compatible USB controller that is connected to a Windows computer (or OS X, but that doesn't matter right now). most USB controllers really only have one place for user input, and that's a button used to start the program.

(unless this is part of the code and I am being very dumb)

Don't be so hard on yourself. You'll get 'em next time.

@samyk You should close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants