Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prod rebased into master #269

Closed
wants to merge 2 commits into from
Closed

prod rebased into master #269

wants to merge 2 commits into from

Conversation

pranavphadke1
Copy link
Collaborator

Purpose

In 2-3 sentences - what does this code actually do, and why?

Tickets

What Trello tickets (if any) are associated with this PR?

Contributors

Who worked on this PR? Tag them with their Github @username for future reference

Use the "Assignees" feature in Github

Feature List

Expand on the purpose - what does this code do, and how? This should be a list of the changes, more in-depth and technical

Pictures

If there are visual changes, show a before/after view, and add a link to the after view using the staging environment.

Reviewers

Primary reviewer:

  • Pick one primary reviewer
    • The team member with the most relevant knowledge about the code area this PR touches
    • NOT an author of the PR
    • If the primary reviewer is the project lead, select two primary reviewers
      • Goal: facilitate knowledge transfer to other team members
    • Primary reviewers are required to approve the PR before it can be merged

Primary:

Use the "Reviewers" feature in Github

Secondary reviewers:

  • Pick as many as appropriate — anyone who would benefit from reading the PR
    • Tag them using their Github usernames below

Secondary:

sebwittr and others added 2 commits May 13, 2024 21:20
* add graduate banner

* update snapshot

* ignore lint issues for svg

* add target

* fix typo

---------

Co-authored-by: Pranav Phadke <91645231+pranavphadke1@users.noreply.github.com>
* Update _variables.scss

* fixed color convention

* remove unused import

* Move Campus and Semester Selection to Sidebar

* Add link to subscriptions page

* update snapshots

* comment out old tests

* remove unused import

* Update [query].tsx
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
searchneu ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:26am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants