Pp/clean up header #266
Merged
Pp/clean up header #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I would create a ticket to update the tests, so its not forgotten next semester. |
|
Minor design feedback, I think the NEU, CPS, LAW buttons would look nicer if they didn't have the white background and they were white themselves. |
sebwittr
approved these changes
Apr 14, 2024
| {userInfo && !macros.isMobile && ( | ||
| <button | ||
| onClick={() => router.push('/subscriptions')} | ||
| className="user-menu__button" |
There was a problem hiding this comment.
I can't see this dropdown on staging because it won't let me sign in. I trust that it looks good though
| @@ -71,6 +135,8 @@ export default function Results(): ReactElement | null { | |||
|
|
|||
| const filtersAreSet: boolean = areFiltersSet(filters); | |||
|
|
|||
| console.log('term', termInfos); | |||
pranavphadke1
added a commit
that referenced
this pull request
May 14, 2024
* Update _variables.scss * fixed color convention * remove unused import * Move Campus and Semester Selection to Sidebar * Add link to subscriptions page * update snapshots * comment out old tests * remove unused import * Update [query].tsx
pranavphadke1
added a commit
that referenced
this pull request
May 14, 2024
This reverts commit 62ff79d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Moves campus and semester selection out of the header and into the sidebar. This is to allow more room for the notifications and faq buttons and also set up for the results page refactoring.
Note: This made 3 tests fail. This is expected and will be fixed later.
Contributors
@pranavphadke1
Feature List
Pictures
Reviewers
Primary:
@sebwittr @soulwa
Secondary:
@ananyaspatil @Anzhuo-W