Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler warnings with Visual Studio 2017 #70

Closed
mattiasljungstrom opened this issue Sep 9, 2019 · 2 comments
Closed

compiler warnings with Visual Studio 2017 #70

mattiasljungstrom opened this issue Sep 9, 2019 · 2 comments
Labels
good first issue Good for newcomers portability Run on more platforms

Comments

@mattiasljungstrom
Copy link

I've been evaluating this library as one possible solution for a project, but I noticed there are quite a lot of warnings when compiling with visual studio 2017.

Examples:
flecs\src\column_system.c(281): warning C4146: unary minus operator applied to unsigned type, result still unsigned
flecs\src\column_system.c(934): warning C4244: '=': conversion from 'uint64_t' to 'uint32_t', possible loss of data
flecs\src\column_system.c(1001): warning C4244: '+=': conversion from 'double' to 'float', possible loss of data
flecs\src\entity.c(1050): warning C4018: '<': signed/unsigned mismatch
flecs\src\entity.c(300): warning C4090: 'function': different 'const' qualifiers
flecs\src\type.c(1068): warning C4244: 'initializing': conversion from 'ecs_entity_t' to 'int', possible loss of data
etc...

Would you be interested in a push request if I keep using this library?

@SanderMertens
Copy link
Owner

@mattiasljungstrom Sure thing! I just built Flecs with pedantic warnings on MacOS and fixed a few warnings that showed up there, but it seems like msvc is catching more. If you can do a PR I'll definitely merge it.

@SanderMertens SanderMertens added the portability Run on more platforms label Sep 14, 2019
@SanderMertens SanderMertens added the good first issue Good for newcomers label Oct 29, 2019
rishubn added a commit to rishubn/flecs that referenced this issue Nov 8, 2019
rishubn added a commit to rishubn/flecs that referenced this issue Nov 9, 2019
rishubn added a commit to rishubn/flecs that referenced this issue Nov 10, 2019
rishubn added a commit to rishubn/flecs that referenced this issue Nov 10, 2019
rishubn added a commit to rishubn/flecs that referenced this issue Nov 13, 2019
@SanderMertens
Copy link
Owner

I've recently fixed a lot of warnings in MSVC related to type conversions and "unsafe" functions, so closing this issue. If you are still seeing issues with MSVC, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers portability Run on more platforms
Projects
None yet
Development

No branches or pull requests

2 participants