Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pygsti is incompatible with scipy 1.12 #391

Closed
eendebakpt opened this issue Jan 21, 2024 · 1 comment · Fixed by #392
Closed

Pygsti is incompatible with scipy 1.12 #391

eendebakpt opened this issue Jan 21, 2024 · 1 comment · Fixed by #392
Labels
bug A bug or regression
Milestone
0.9.12.1

Comments

@eendebakpt
Copy link
Contributor

Describe the bug
Using pygsti fails on the import of colvolve from scipy (which is no longer available from the main scipy namespace in version 1.12)

To Reproduce
Steps to reproduce the behavior:

  1. Install scipy 1.12 (latest on pypi) and pygsti
  2. Using pygsti fails on the import of colvolve from scipy at line

pyGSTi/pygsti/extras/drift/signal.py

Line 13 in 7411a00

from scipy import convolve as _convolve

Environment (please complete the following information):

  • pyGSTi version [e.g. v0.9.7.4] '0.9.10.1.post449'
  • python version [e.g. 3.7, 2.7] 3.11
  • OS [e.g. OSX 10.14, Ubuntu 16.04 LTS] Windows
@eendebakpt eendebakpt added the bug A bug or regression label Jan 21, 2024
@eendebakpt eendebakpt mentioned this issue Jan 22, 2024
Merged
@sserita sserita added the fixed-but-not-in-release-yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Jan 22, 2024
@sserita sserita added this to the 0.9.12.1 milestone Jan 22, 2024
@sserita
Copy link
Contributor

sserita commented Jan 22, 2024

Fixed in #392

@sserita sserita closed this as completed Jan 22, 2024
@sserita sserita removed the fixed-but-not-in-release-yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug or regression
Projects
None yet
Milestone
0.9.12.1
Development

Successfully merging a pull request may close this issue.

Fix convolve import for scipy 3.12 eendebakpt/pyGSTi
2 participants
@eendebakpt @sserita