Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected file in test_packages #381

Closed
coreyostrove opened this issue Dec 5, 2023 · 2 comments
Closed

Unexpected file in test_packages #381

coreyostrove opened this issue Dec 5, 2023 · 2 comments
Assignees
Labels
bug A bug or regression
Milestone

Comments

@coreyostrove
Copy link
Contributor

coreyostrove commented Dec 5, 2023

This is primarily a question for @enielse. I'm working through some changes in test_packages and noticed an unexpected file in test_packages\drivers called nqubitconstruction.py. This isn't a test module, but rather looks to me like it might be an early/outdated version of the cloud noise model code. I suspect this is probably from when you were originally testing that code and it probably slipped into a commit by accident, and therefore can be safely deleted. But I wanted to run that by you first before I did so. It might also be worth having you take a look to make sure there aren't any functions or code within that ought to be preserved before we remove it entirely. Thoughts?

@coreyostrove coreyostrove added the bug A bug or regression label Dec 5, 2023
@coreyostrove coreyostrove added this to the 0.9.12.1 milestone Dec 5, 2023
@enielse
Copy link
Collaborator

enielse commented Dec 12, 2023

This looks fine to remove to me. The code in nqubitconstruction.py has been incorporated into pygsti proper. I believe earlier on this file was used by the unit tests but since adding functionality to the cloud crosstalk models this is no longer needed.

sserita added a commit that referenced this issue Dec 13, 2023
Removes a spurious file in test_packages/drivers.
@sserita
Copy link
Contributor

sserita commented Dec 13, 2023

Thanks @enielse! I've removed this file in my bugfix-release-0.9.12.1 branch which I plan to use as a catchall for several of the smaller bugfixes for the next release.

@sserita sserita added the fixed-but-not-in-release-yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Dec 13, 2023
@sserita sserita closed this as completed Jan 31, 2024
@sserita sserita removed the fixed-but-not-in-release-yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or regression
Projects
None yet
Development

No branches or pull requests

3 participants