You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Clicking "Go" when using the batch runs mode in QuESt Valuation before viewing the parameters screen results in a fatal crash. This is because data validation that is executed on pressing the "go" button checks for parameter values. However, the parameter widgets that it checks are not created until on_enter of the parameter screen. Hence, an AttributeError or similar is thrown, resulting in a fatal crash.
Steps to replicate
Open the batch runs mode in QuESt Valuation.
Provide any market area, value stream, node, historical data options.
Click the "go" button to execute without clicking the toggle to view the parameters screen.
The intended behavior here is that the default values should be used.
Action items
Currently on the development branch for v1.2.e, a warning popup catches this situation and indicates that parameters should be set. However, this does not match the intent of the design.
Either disable the "go" button until the parameters screen is viewed or redesign the GUI such that the process is more sequential like the wizard (e.g., hide access to an execute/"go" button until all steps are completed).
The text was updated successfully, but these errors were encountered:
Summary of issue
Clicking "Go" when using the batch runs mode in QuESt Valuation before viewing the parameters screen results in a fatal crash. This is because data validation that is executed on pressing the "go" button checks for parameter values. However, the parameter widgets that it checks are not created until on_enter of the parameter screen. Hence, an AttributeError or similar is thrown, resulting in a fatal crash.
Steps to replicate
The intended behavior here is that the default values should be used.
Action items
Currently on the development branch for v1.2.e, a warning popup catches this situation and indicates that parameters should be set. However, this does not match the intent of the design.
Either disable the "go" button until the parameters screen is viewed or redesign the GUI such that the process is more sequential like the wizard (e.g., hide access to an execute/"go" button until all steps are completed).
The text was updated successfully, but these errors were encountered: