Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "Go" when using the batch runs mode in QuESt Valuation before viewing the parameters screen results in a fatal crash #20

Open
rconcep opened this issue Oct 1, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@rconcep
Copy link
Contributor

rconcep commented Oct 1, 2019

Summary of issue

Clicking "Go" when using the batch runs mode in QuESt Valuation before viewing the parameters screen results in a fatal crash. This is because data validation that is executed on pressing the "go" button checks for parameter values. However, the parameter widgets that it checks are not created until on_enter of the parameter screen. Hence, an AttributeError or similar is thrown, resulting in a fatal crash.

Steps to replicate

  1. Open the batch runs mode in QuESt Valuation.
  2. Provide any market area, value stream, node, historical data options.
  3. Click the "go" button to execute without clicking the toggle to view the parameters screen.

The intended behavior here is that the default values should be used.

Action items

  • Currently on the development branch for v1.2.e, a warning popup catches this situation and indicates that parameters should be set. However, this does not match the intent of the design.

  • Either disable the "go" button until the parameters screen is viewed or redesign the GUI such that the process is more sequential like the wizard (e.g., hide access to an execute/"go" button until all steps are completed).

@rconcep rconcep added the bug Something isn't working label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant