Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design stuff #1

Closed
kevinboulain opened this issue Aug 18, 2018 · 1 comment
Closed

Design stuff #1

kevinboulain opened this issue Aug 18, 2018 · 1 comment

Comments

@kevinboulain
Copy link

From the README.md, it looks like you want to rework the thread & socket management. The Python community seems to have shifted to the asynchronous IO paradigm. It could probably give cleaner code & better performance.
For a small project build from scratch that doesn't need to leverage other libraries I would recommend curio (much easier to grasp and has less pitfalls than asyncio or there is trio which I never used but is inspired by curio's design principles).
I'll let you look at the examples to see how much the a client/server implementation may be cleaner.

Also, it seems you require root permissions so why don't you bring up a real tunnel and handle more than TCP by creating TUN or TAP devices (by opening /dev/net/tun on Linux)? It's easy to do with Python, if a bit obscur (since you'll have to define a couple of things yourself instead of relying on header files). The downside being you'll probably need to assign IP addresses on both sides.

@kevinboulain
Copy link
Author

Closing, not a real issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant