CD-hit threads limit #211
Merged
CD-hit threads limit #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I use it with 72 threads all the time. Never had it crash. Could be a rare race condition. |
|
If you run cd-hit directly: do you get this error message: Certainly on the system I'm using you have to compile cd-hit differently to get multi-threading support, the default appears to be to be sequential. |
|
Yes it works for me. It's because I use the homebrew-science to install it, which enables OpenMP. The message you get isn't an error - but just a warning? The default for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its been reported that CD-hit crashes when its given more than ~50 threads. This PR introduces a hard limit of 40 to be on the safe side.
Also labels in the roary_plots.py & R scripts have been made consistent with the other figures.