GPL-770-2 Update the get cherrypicked samples queries for the new Beckman events

[Chris-Friend]

User story
See sanger/lighthouse#228 for main issue. This just represents the changes required to crawler

Who are the primary contacts for this story
Katy T
Phil
Chris F

Acceptance criteria
To be considered successful the solution must allow:

• Update crawler methods to get cherrypicked samples to query for both Sentinel or Beckman cherrypicking events (introduced as part of GPL-733 As a developer I would like to run a Manual MLWH and DART Migration #144)

Dependencies
This story is blocked by the following dependencies:

• GPL-733 As a developer I would like to run a Manual MLWH and DART Migration #144

Additional context
Add any other context or screenshots about the feature request here.

[rl15]

#144

[rl15]

PSD to test
What samples have been CP
+ves report
Something else

[KatyTaylor]

Clarification of above comment.

To test this:

1. This 'get cherrypicked samples' functionality is used in the 'Add Legacy Samples to DART Migration' (update_dart.py) - it does not migrate samples that have already been cherrypicked.
   • samples that have been cherrypicked using Sentinel (have 'cherrypick_layout_set' event) should not be migrated
   • samples that have been cherrypicked using Beckman (have 'lh_beckman_cp_destination_created' event) should not be migrated
2. This 'get cherrypicked samples' functionality is used in the 'Update Filtered Positives Migration' (update_filtered_positives.py) - it does not update the filtered positive fields on samples that have already been cherrypicked.
   • samples that have been cherrypicked using Sentinel (have 'cherrypick_layout_set' event) should not be updated
   • samples that have been cherrypicked using Beckman (have 'lh_beckman_cp_destination_created' event) should not be updated
   • (to clarify, this functionality is not used in the 'Assign Filtered Positive Fields to Legacy Samples Migration' (update_legacy_filtered_positives.py)

[Chris-Friend]

Clarification of above comment.

To test this:

1. This 'get cherrypicked samples' functionality is used in the 'Add Legacy Samples to DART Migration' (update_dart.py) - it does not migrate samples that have already been cherrypicked.

   • samples that have been cherrypicked using Sentinel (have 'cherrypick_layout_set' event) should not be migrated
   • samples that have been cherrypicked using Beckman (have 'lh_beckman_cp_destination_created' event) should not be migrated

2. This 'get cherrypicked samples' functionality is used in the 'Update Filtered Positives Migration' (update_filtered_positives.py) - it does not update the filtered positive fields on samples that have already been cherrypicked.

   • samples that have been cherrypicked using Sentinel (have 'cherrypick_layout_set' event) should not be updated
   • samples that have been cherrypicked using Beckman (have 'lh_beckman_cp_destination_created' event) should not be updated
   • (to clarify, this functionality is not used in the 'Assign Filtered Positive Fields to Legacy Samples Migration' (update_legacy_filtered_positives.py)

Further clarification of last point: the functionality is not used in updating legacy samples with filtered positive values as we expect this migration to be run before the Beckman workflow was in use