Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): activate PTE input when dragging files #6929

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

sjelfull
Copy link
Member

Description

After the change in #6867 you have to activate the PTE before you are able to drag files into the PTE.

This change fixes that situation by activating the PTE whenever the drag starts.

What to review

  • That the PTE activates when you start dragging files into it.

Notes for release

  • Fixes a issue where the PTE won't activate when you start dragging files into it

Signed-off-by: Fred Carlsen <fred@sjelfull.no>
@sjelfull sjelfull self-assigned this Jun 13, 2024
@sjelfull sjelfull requested a review from a team as a code owner June 13, 2024 11:57
@sjelfull sjelfull requested review from ricokahler and removed request for a team June 13, 2024 11:57
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:59am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:59am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:59am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:59am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:59am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jun 13, 2024 11:59am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jun 13, 2024 12:07 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 51s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 13s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 6s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 28s 12 0 0

Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjelfull sjelfull added this pull request to the merge queue Jun 13, 2024
Merged via the queue into next with commit f589698 Jun 13, 2024
42 of 43 checks passed
@sjelfull sjelfull deleted the fix/activate-pte-on-dragenter branch June 13, 2024 13:06
juice49 pushed a commit that referenced this pull request Jun 13, 2024
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants