Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Handle commas in numbers #13

Open
sanity opened this Issue · 0 comments

2 participants

@sanity
Owner

LastCalc currently outputs numbers with commas, like 35,523,433 - however it cannot parse numbers with commas.

The issue is lists, is [123,456] a list with two numbers, 123 and 456, or the number 123456?

It's hard to think of a robust solution. eg. we could look out specifically for up to 3 digits, followed by one or more sets of 3 digits all separated by a comma, with no space. This may be sufficient, but could lead to misunderstandings in some circumstances.

In any case, this should occur in the Tokenizer, and also in the javascript so that numbers can be highlighted as the user types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.