Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle commas in numbers #13

Open
sanity opened this issue May 4, 2012 · 0 comments
Open

Handle commas in numbers #13

sanity opened this issue May 4, 2012 · 0 comments

Comments

@sanity
Copy link
Owner

sanity commented May 4, 2012

LastCalc currently outputs numbers with commas, like 35,523,433 - however it cannot parse numbers with commas.

The issue is lists, is [123,456] a list with two numbers, 123 and 456, or the number 123456?

It's hard to think of a robust solution. eg. we could look out specifically for up to 3 digits, followed by one or more sets of 3 digits all separated by a comma, with no space. This may be sufficient, but could lead to misunderstandings in some circumstances.

In any case, this should occur in the Tokenizer, and also in the javascript so that numbers can be highlighted as the user types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants