Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug when using maxFP/curve_max_FP #30

Closed
alexblnn opened this issue Sep 22, 2021 · 2 comments
Closed

Potential bug when using maxFP/curve_max_FP #30

alexblnn opened this issue Sep 22, 2021 · 2 comments
Labels
wontfix This will not be worked on

Comments

@alexblnn
Copy link
Collaborator

we need to be careful using the k_min idea (see #29) and computing bounds. If a sliced template (i.e. thr[k_min:]) is given as input to maxFP or curve_max_FP we give over optimistic bounds, since those functions assume that the templates starts at k=1 (see https://github.com/pneuvial/sanssouci.python/blob/main/sanssouci/post_hoc_bounds.py#L56)

@pneuvial
Copy link
Collaborator

As discussed a workaround seems to force thr[0:(k_min-1)] to be 0 instead of slicing the template. This should have the effect to make the k < k_min suboptimal in the calculation of the bound.

@pneuvial pneuvial added the wontfix This will not be worked on label Mar 17, 2022
@pneuvial
Copy link
Collaborator

The k_min idea has been abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants