You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed a workaround seems to force thr[0:(k_min-1)] to be 0 instead of slicing the template. This should have the effect to make the k < k_min suboptimal in the calculation of the bound.
we need to be careful using the k_min idea (see #29) and computing bounds. If a sliced template (i.e. thr[k_min:]) is given as input to maxFP or curve_max_FP we give over optimistic bounds, since those functions assume that the templates starts at k=1 (see https://github.com/pneuvial/sanssouci.python/blob/main/sanssouci/post_hoc_bounds.py#L56)
The text was updated successfully, but these errors were encountered: