Implement a working dev server #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sansyrox
commented
Jul 5, 2021
|
@JackThomson2 , can you please have a look at the approach of this PR? The implementation is clearly hacky needs improvement however I believe since it is a dev mode feature only and gets the hot reload to work it is a decent way. What do you think? |
|
@sansyrox sure I'll try take a look this weekend if that's alright, busy week unfortunately |
@JackThomson2 , yep yep 🖖 |
sansyrox
commented
Jul 6, 2021
robyn/__init__.py
Outdated
| from .robyn import Server | ||
| from asyncio import iscoroutinefunction | ||
| from .responses import static_file, jsonify | ||
|
|
||
| from watchdog.observers import Observer |
There was a problem hiding this comment.
need to include this as a dev dependency in pyproject.toml
sansyrox
force-pushed
the
dev_server
branch
5 times, most recently
from
0fd48f1
to
3a2d453
Compare
sansyrox
force-pushed
the
dev_server
branch
2 times, most recently
from
905fd97
to
2eedc93
Compare
sansyrox
commented
Jul 15, 2021
|
This works well on all machines. Something wrong with the pythoning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not merge as Pyo3 is not compiling on Mac OS and am unable to test the implementation.