Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace integer status codes with Enum values of StatusCodes #436

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Replace integer status codes with Enum values of StatusCodes #436

merged 4 commits into from
Mar 9, 2023

Conversation

Noborita9
Copy link
Contributor

Description
Replace integer status codes with Enum values of StatusCodes for better readability and consistency
This PR fixes #

@netlify
Copy link

netlify bot commented Mar 6, 2023 •
edited
Loading

✅ Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit c617d96
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/64092b427ea1b50008a90bea

@Noborita9 Noborita9 marked this pull request as ready for review March 6, 2023 19:50
sansyrox
sansyrox approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Noborita9 .

Thank you! 😄

sansyrox
sansyrox reviewed Mar 9, 2023
View reviewed changes
robyn/router.py Outdated Show resolved Hide resolved
@sansyrox
Copy link
Member

sansyrox commented Mar 9, 2023

Great work @Noborita9 😄

@sansyrox sansyrox merged commit 0569bc5 into sparckles:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noborita9 @sansyrox