Add the base of http requests #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JackThomson2 @messense , I tried adding directory serving in actix here(https://github.com/sansyrox/robyn/pull/78/files#diff-48d27698cc708c7efe770fd897e4885efaa0a15cae30d54936068603ba03bbd9R71) . However, it is not allowing me serve request apart from GET. Do you folks know where I might be going wrong? |
sansyrox
force-pushed
the
http_request_finalise
branch
3 times, most recently
from
06aef66
to
29163d1
Compare
sansyrox
force-pushed
the
http_request_finalise
branch
from
29163d1
to
ca89857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the base of http compliance. Need to add more specifications per route!
https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods