Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 9: Support both AMD or CommonJS by using UMD returnExports #12

Merged
merged 1 commit into from
May 11, 2014

Conversation

rxaviers
Copy link
Contributor

Use UMD returnExports https://github.com/umdjs/umd/blob/master/returnExports.js in order to support both AMD or CommonJS.

  • Does tests pass?
  • Is coding standards correct?

@rxaviers
Copy link
Contributor Author

I ran tests following README instructions and it passes just fine.

@rxaviers rxaviers changed the title Fix 9: Support either AMD or CommonJS by using UMD returnExports Fix 9: Support both AMD or CommonJS by using UMD returnExports Apr 30, 2014
santhoshtr added a commit that referenced this pull request May 11, 2014
Fix 9: Support both AMD or CommonJS by using UMD returnExports
@santhoshtr santhoshtr merged commit 1536df5 into santhoshtr:master May 11, 2014
@santhoshtr
Copy link
Owner

Thanks!.
(sorry for the delay, I was traveling)

@rxaviers
Copy link
Contributor Author

Thanks (not a problem at all).

@rxaviers rxaviers deleted the fix-9-UMD branch May 11, 2014 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants