Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 after clicking on the internal link in the official website document #39

Closed
2 tasks done
callqh opened this issue Sep 27, 2022 · 3 comments
Closed
2 tasks done

Comments

@callqh
Copy link
Contributor

callqh commented Sep 27, 2022

Describe the bug

document url
image

The address in the documentation is . /islands-arch, so the jump fails. Do I need to change it to . /guide/islands-arch?
And I checked the code, in the remarkPluginNormalizeLink file node.url = path.join(base, url) is written like this, do I need to recognize the path where the file itself is located to splice, instead of using base directly?

I'm also confused about which is the correct way. ^^

Reproduction

  1. Click on the internal links in the document

Expected behavior

Correct page jumping

System Info

System:
    OS: macOS 12.6
    CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
    Memory: 834.75 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.19.2 - ~/.nvm/versions/node/v14.19.2/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.17 - ~/.nvm/versions/node/v14.19.2/bin/npm
    Watchman: 2021.06.07.00 - /usr/local/bin/watchman
  Browsers:
    Chrome: 105.0.5195.125
    Safari: 16.0

Additional context

No response

Validations

  • Read the docs
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@sanyuan0704
Copy link
Owner

I think it's better to change the url to /guide/islands-arch

@callqh
Copy link
Contributor Author

callqh commented Sep 27, 2022

I think it's better to change the url to /guide/islands-arch

ok

@codersjj
Copy link
Contributor

codersjj commented Aug 2, 2023

The documentation says the default value of base is /, but if I don't explicitly set it, the default value of base doesn't seem to be /, and the button Take me home also doesn't work.

take-me-home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants