Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add modal property to Popover control #12210

Closed
egorwow70 opened this issue Aug 1, 2024 · 3 comments · Fixed by #12360
Closed

[FEATURE REQUEST] Add modal property to Popover control #12210

egorwow70 opened this issue Aug 1, 2024 · 3 comments · Fixed by #12360
Assignees

Comments

@egorwow70
Copy link

Is this a bug, enhancement, or feature request?

It is a feature request.

Describe your proposal.

Is it possible to add a "modal" property to the Popover control like it is working in sapui5? https://sapui5.hana.ondemand.com/#/api/sap.m.Popover%23constructor

image

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

  • Angular 17.3.1
  • FundamentalNGX 0.51.1 (current available version)

Did you check the documentation and the API?

Yes, I didn't find it here - https://sap.github.io/fundamental-ngx/#/core/popover/api

@droshev
Copy link
Contributor

droshev commented Aug 2, 2024

@egorwow70 we have an input for that closeOnOutsideClick

@alexhristov14
Copy link
Contributor

@egorwow70 In the api tab, if you select the PopoverComponent file, you will find the closeOnOutsideClick input which is essentially the same as the modal property as commented above.

@egorwow70
Copy link
Author

@alexhristov14

Hello, sorry for the late response, I think they are different, because closeOnOutsideClick controls whether the control can be closed by outside click. But modal property in sapui5 makes the outside background black and you cannot close it by clicking outside anymore.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants