Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue In Combobox Field Delete Search Term With Chinese Characters #12232

Closed
claudiuzsap opened this issue Aug 6, 2024 · 0 comments · Fixed by #12340
Closed

Issue In Combobox Field Delete Search Term With Chinese Characters #12232

claudiuzsap opened this issue Aug 6, 2024 · 0 comments · Fixed by #12340
Assignees
Labels

Comments

@claudiuzsap
Copy link

claudiuzsap commented Aug 6, 2024

Is this a bug, enhancement, or feature request?

Bug

Can you handle that on the application side

Unfortunately not

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Latest

If this is a bug, please provide steps for reproducing it; the exact components you are using;

  1. Add Pinyin - Traditional Chinese language keyboard in your system
  2. Navigate to Fundamental NGX documentation website on Combobox Field: https://sap.github.io/fundamental-ngx/#/core/combobox
  3. Go to first Combobox field example which has 5 fruits as options: Apple, Pineapple, etc.
  4. Select any option from the Combobox field (ex: Apple)
  5. Make sure to have activated the new Chinese language
  6. In the Search Input after the selected option (ex: Apple) add any Chinese character without using copy paste of a Chinese character, it is needed to be typed from the keyboard (My guess is that here is the problem because a Chinese character if you type it from the keyboard, after you press a keyboard letter then you have to choose using a number what variant of that character you want to use. Also if you don't have any value selected the issue is not reproducible, this could be also a hint)
  7. Then try to delete characters from search term of Combobox and you will see that the Combobox search term got into a broken state and is stuck (In the video attached after I made the same steps I was pressing Backspace continuously and couldn't delete the search term because it got stuck. Switching to another option of the Combobox didn't fix the state)

Related to this ticket: #10710

Issue.chinese.characters.in.search.term.mov

It's a customer facing issue.

@droshev droshev added the i18n label Aug 7, 2024
khotcholava pushed a commit that referenced this issue Aug 30, 2024
…of characters

closes [#12232](#12232)

## Description
- Added handling for `compositionstart` and `compositionend` events to properly manage IME input (e.g., Chinese, Japanese).
- Introduced `isComposing` flag to bypass autocomplete logic during IME composition.
- Updated `inputText` synchronization after IME input ends to ensure it matches the finalized value.
- Prevented unwanted modifications of input value when using IME, addressing the issue where typing and deleting partially composed characters could remove the last English character.
khotcholava pushed a commit that referenced this issue Aug 30, 2024
…of characters

closes [#12232](#12232)

## Description
- Added handling for `compositionstart` and `compositionend` events to properly manage IME input (e.g., Chinese, Japanese).
- Introduced `isComposing` flag to bypass autocomplete logic during IME composition.
- Updated `inputText` synchronization after IME input ends to ensure it matches the finalized value.
- Prevented unwanted modifications of input value when using IME, addressing the issue where typing and deleting partially composed characters could remove the last English character.
khotcholava pushed a commit that referenced this issue Aug 30, 2024
…of characters

closes [#12232](#12232)

## Description
- Added handling for `compositionstart` and `compositionend` events to properly manage IME input (e.g., Chinese, Japanese).
- Introduced `isComposing` flag to bypass autocomplete logic during IME composition.
- Updated `inputText` synchronization after IME input ends to ensure it matches the finalized value.
- Prevented unwanted modifications of input value when using IME, addressing the issue where typing and deleting partially composed characters could remove the last English character.
khotcholava added a commit that referenced this issue Aug 30, 2024
…of characters

closes [#12232](#12232)

## Description
- Added handling for `compositionstart` and `compositionend` events to properly manage IME input (e.g., Chinese, Japanese).
- Introduced `isComposing` flag to bypass autocomplete logic during IME composition.
- Updated `inputText` synchronization after IME input ends to ensure it matches the finalized value.
- Prevented unwanted modifications of input value when using IME, addressing the issue where typing and deleting partially composed characters could remove the last English character.
khotcholava added a commit that referenced this issue Sep 4, 2024
…deletion of characters

closes [#12232](#12232)

## Description
Fixed `isComposing` prefix
droshev pushed a commit that referenced this issue Sep 10, 2024
…deletion of characters (#12340)

* fix(core): handle IME input correctly to prevent accidental deletion of characters

closes [#12232](#12232)

## Description
- Added handling for `compositionstart` and `compositionend` events to properly manage IME input (e.g., Chinese, Japanese).
- Introduced `isComposing` flag to bypass autocomplete logic during IME composition.
- Updated `inputText` synchronization after IME input ends to ensure it matches the finalized value.
- Prevented unwanted modifications of input value when using IME, addressing the issue where typing and deleting partially composed characters could remove the last English character.

* fix(core): combobox handle IME input correctly to prevent accidental deletion of characters

closes [#12232](#12232)

## Description
Fixed `isComposing` prefix
@droshev droshev added this to the Sprint 138 - September 2024 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment